refactor: Remove api_key from serialization of AzureOCRDocumentConverter and SerperDevWebSearch#6150
Merged
anakin87 merged 5 commits intodeepset-ai:mainfrom Oct 23, 2023
Conversation
github-actions
bot
added
topic:tests
type:documentation
anakin87
reviewed
Oct 23, 2023
Member
anakin87
left a comment
anakin87
left a comment
There was a problem hiding this comment.
Thanks for another good PR!
I left a comment.
I also suggest adding a test_init_fail_wo_api_key to test_serperdev.
Member
|
Your PR is ready to go! 🎉 |
anakin87
approved these changes
Oct 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
api_keyfrom serialization ofAzureOCRDocumentConverter,SerperDevWebSearch,RemoteWhisperTranscriber2.0 #6116Proposed Changes:
Remove
api_keyfrom serialization ofAzureOCRDocumentConverterandSerperDevWebSearchHow did you test it?
Unit Tests have been updated to test the serialization without
api_key.Notes for the reviewer
I have opened a PR (#6149) for migrating
RemoteWhisperTranscriberto the OpenAI SDK. TheRemoteWhisperTranscriberimplementation in that PR does not serialize theapi_keyand is fixed as part of that PR.Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.